Fri Aug 31 09:30:38 PDT 2007
- Previous message: [Slony1-general] Re: Bug in slonik SQL parser: comments are not removed properly
- Next message: [Slony1-general] Re: Bug in slonik SQL parser: comments are not removed properly
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 8/31/2007 9:51 AM, Andrew Sullivan wrote: > On Thu, Aug 30, 2007 at 11:18:07PM -0400, Jan Wieck wrote: >> Exactly. We don't have enough developers. And I truly think that we have >> much bigger fish to fry than supporting complicated comment structures. > > That's ok with me; my point is just that we can't dismiss this. So. > . . > >> The way I see it is that we will change our parser to simply REJECT a >> DDL script if there is any /* style comment in there at all, document it >> that way and be done with it. At least it won't allow to break >> replication any more. > > . . .this sounds ok to me. The non-breaking part is what's > important. What gets me puzzled about it is that the script apparently did execute on the origin (where all DDL is injected unless it is EXECUTE ONLY ON), but later on breaks on a subscriber. Slonik and slon use the same parser to split the statements. So how did that happen? Jan -- #======================================================================# # It's easier to get forgiveness for being wrong than for being right. # # Let's break this rule - forgive me. # #================================================== JanWieck at Yahoo.com #
- Previous message: [Slony1-general] Re: Bug in slonik SQL parser: comments are not removed properly
- Next message: [Slony1-general] Re: Bug in slonik SQL parser: comments are not removed properly
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Slony1-general mailing list