Christopher Browne cbbrowne at ca.afilias.info
Tue Apr 17 09:03:10 PDT 2007
Bill Moran <wmoran at collaborativefusion.com> writes:
> No objection, but possibly a comment.
>
> I don't see any changes to initializeLocalNode() in your patch.  It looks
> like this line can come out:
>
>         perform setval(''@NAMESPACE at .sl_rowid_seq'',
>                         p_local_node_id::int8 * ''1000000000000000''::int8);
>
> Additionally, sl_rowid_seq can probably be removed from the schema.  As
> far as I can tell, the only purpose it serves it to provide unique IDs for
> rows without PKs.
>
> I'll try to put together a patch, but I wanted to throw this out in case
> I'm unable to find time to submit a proper patch.

Excellent point.

I'm in the process of revising the patch to reflect that change, as
well as to include documentation changes.
-- 
(reverse (concatenate 'string "ofni.sailifa.ac" "@" "enworbbc"))
<http://dba2.int.libertyrms.com/>
Christopher Browne
(416) 673-4124 (land)


More information about the Slony1-general mailing list