The following is not about this particular commit, but more general 
about what is going on.

Yesterday I got an "RC1" tarball from Chris, only to discover that the 
ducttape test_x_pgbench scripts don't finish any more. The database 
comparision at the end has been moved out into a script part that is 
sourced in, but the source syntax doesn't take parameters, at least not 
in a standard Bourne shell. The change responsible for that was done 
nearly a month ago and not discovered. This makes me wonder on how many 
platforms this change was tested.

Now we have changes to the build system AFTER the tree has been tagged 
as Release Candidate.

This is really not the way to ensure the quality of the upcoming 
release. I call this modus operandi a sure recipe for a release with a 
lot of trouble.

Chris, since the RC1 tarball was not uploaded thus far I suggest we fix 
the scripts, make sure they and the changes to the build system pass a 
decent number of different platforms and then "retag" (move the rc1 tag) 
for a new tarball.


Jan


On 6/2/2005 4:00 AM, CVS User Account wrote:

> Log Message:
> -----------
> 
> 
> Move --with-docdir definition, it breaks builds in the previous version.
> 
> Modified Files:
> --------------
>     slony1-engine:
>         postgresql-slony1-engine.spec.in (r1.12 -> r1.13)
>     slony1-engine/redhat:
>         slony-I.spec (r1.2 -> r1.3)
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: postgresql-slony1-engine.spec.in
> ===================================================================
> RCS file: /usr/local/cvsroot/slony1/slony1-engine/postgresql-slony1-engine.spec.in,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -Lpostgresql-slony1-engine.spec.in -Lpostgresql-slony1-engine.spec.in -u -w -r1.12 -r1.13
> --- postgresql-slony1-engine.spec.in
> +++ postgresql-slony1-engine.spec.in
> @@ -48,9 +48,9 @@
>          --with-perltools=%{_bindir} \
>  %endif
>  %if %docs
> -        --with-docs --with-docdir=/usr/share/doc \
> +        --with-docs \
>  %endif
> -        --datadir %{_datadir}/pgsql --sysconfdir=/etc --with-pglibdir=%{_libdir}/pgsql 
> +        --datadir %{_datadir}/pgsql --sysconfdir=/etc --with-pglibdir=%{_libdir}/pgsql --with-docdir=/usr/share/doc 
>  make
>  %if %perltools
>   cd tools
> Index: slony-I.spec
> ===================================================================
> RCS file: /usr/local/cvsroot/slony1/slony1-engine/redhat/slony-I.spec,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -Lredhat/slony-I.spec -Lredhat/slony-I.spec -u -w -r1.2 -r1.3
> --- redhat/slony-I.spec
> +++ redhat/slony-I.spec
> @@ -48,9 +48,9 @@
>          --with-perltools=%{_bindir} \
>  %endif
>  %if %docs
> -        --with-docs --with-docdir=/usr/share/doc \
> +        --with-docs \
>  %endif
> -        --datadir %{_datadir}/pgsql --sysconfdir=/etc --with-pglibdir=%{_libdir}/pgsql
> +        --datadir %{_datadir}/pgsql --sysconfdir=/etc --with-pglibdir=%{_libdir}/pgsql --with-docdir=/usr/share/doc 
>  make
>  %if %perltools
>   cd tools
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Slony1-commit mailing list
> Slony1-commit at gborg.postgresql.org
> http://gborg.postgresql.org/mailman/listinfo/slony1-commit


-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck at Yahoo.com #