Bug 31 - PGLIBDIR/perlsharedir confusion
Summary: PGLIBDIR/perlsharedir confusion
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: altperl (show other bugs)
Version: devel
Hardware: Other Other
: medium normal
Assignee: Peter Eisentraut
URL:
Depends on:
Blocks:
 
Reported: 2008-01-04 02:40 UTC by Peter Eisentraut
Modified: 2008-02-14 08:42 UTC (History)
1 user (show)

See Also:

Attachments
Proposed patch... (11.40 KB, patch)
2008-01-04 13:34 UTC, Christopher Browne 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Eisentraut 2008-01-04 02:40:29 UTC 
In revision 1.16 of /slony1-engine/tools/altperl/Makefile you attempted to fix an earlier bug report of mine,

"""
Use perlsharedir rather than pglibdir to indicate (in altperl tools) where
the main .pm file is installed.
"""

But you actually changed "pglibdir" to "pgsharedir", which is still wrong.  It has to be "perlsharedir", because later in the same Makefile you do

$(INSTALL_DATA) slon-tools $(DESTDIR)$(perlsharedir)/slon-tools.pm

and these two should be consistent.
Comment 1 Christopher Browne 2008-01-04 13:34:01 UTC 
Created attachment 7 [details]
Proposed patch...

Peter, here's a patch which changes over to use PERLSHAREDIR in all of the scripts, and substitutes that consistently across the various .pl files

Does this seem to better address the issue?
Comment 2 Peter Eisentraut 2008-02-14 07:05:07 UTC 
That looks about right.
Comment 3 Christopher Browne 2008-02-14 08:42:36 UTC 
Changes applied to CVS:
http://lists.slony.info/pipermail/slony1-commit/2008-February/002175.html