Bug 263 - cannot specify CPPFLAGS or LDFLAGS on configure command line
Summary: cannot specify CPPFLAGS or LDFLAGS on configure command line
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: other scripts (show other bugs)
Version: devel
Hardware: PC Linux
: low normal
Assignee: Slony Bugs List
URL:
: 277 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-29 11:22 UTC by Peter Eisentraut
Modified: 2012-09-04 14:34 UTC (History)
1 user (show)

See Also:

Attachments
patch (572 bytes, application/octet-stream)
2012-02-29 11:22 UTC, Peter Eisentraut 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Eisentraut 2012-02-29 11:22:33 UTC 
Created attachment 144 [details]
patch

Normally, one should be able to do

./configure --flags ... CPPFLAGS='...' CFLAGS='...' LDFLAGS='...'

With slony, this works for CFLAGS, but CPPFLAGS and LDFLAGS are not recorded in Makefile.global.  If this were added, some assignments in Makefile.global because redundant, because the variable already contains the relevant values from configure.  See attached patch.

The background is that distribution package build routines nowadays pass extra "hardening" flags to the build via these variables, but slony currently ignores them except for the ones in CFLAGS.
Comment 1 Steve Singer 2012-06-12 11:35:08 UTC 
Thanks for the patch
This has been committed to master.
http://git.postgresql.org/gitweb/?p=slony1-engine.git;a=commit;h=671b724ceed0c82431e5a117f4b01210febd8b9a
Comment 2 Christopher Browne 2012-09-04 14:34:52 UTC 
*** Bug 277 has been marked as a duplicate of this bug. ***