Bug 227 - slonik tries to add views to a set
Summary: slonik tries to add views to a set
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: slonik (show other bugs)
Version: devel
Hardware: PC Linux
: low enhancement
Assignee: Steve Singer
URL:
Depends on:
Blocks:
 
Reported: 2011-07-29 05:56 UTC by Steve Singer
Modified: 2011-07-29 07:21 UTC (History)
1 user (show)

See Also:

Attachments
add a test case for this issue (890 bytes, patch)
2011-07-29 05:57 UTC, Steve Singer 		Details
patch to fix the issue (1008 bytes, patch)
2011-07-29 05:57 UTC, Steve Singer 		Details
related documentation fix (1.39 KB, patch)
2011-07-29 05:57 UTC, Steve Singer 		Details
additional doc fix (669 bytes, patch)
2011-07-29 05:58 UTC, Steve Singer 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Singer 2011-07-29 05:56:27 UTC 
This was reported against 2.1.0 b3 by a tester

If you have a database schema with views and try to add all of the tables in the schema, ie  'set add table(set id=1, tables='public.x*'); 
it will try to add the view to the set but fail.
Comment 1 Steve Singer 2011-07-29 05:57:11 UTC 
Created attachment 113 [details]
add a test case for this issue
Comment 2 Steve Singer 2011-07-29 05:57:31 UTC 
Created attachment 114 [details]
patch to fix the issue
Comment 3 Steve Singer 2011-07-29 05:57:59 UTC 
Created attachment 115 [details]
related documentation fix
Comment 4 Steve Singer 2011-07-29 05:58:25 UTC 
Created attachment 116 [details]
additional doc fix
Comment 5 Steve Singer 2011-07-29 06:02:13 UTC 
A fix for this bug is attached or available at 

https://github.com/ssinger/slony1-engine/tree/bug227

Please arrange for a review.

The patch also includes a fix for related problem with regex escaping
Comment 6 Jan Wieck 2011-07-29 06:29:40 UTC 
Patch looks good to me.
Comment 7 Steve Singer 2011-07-29 07:21:02 UTC 
Committed to master for the next 2.1.0 whatever release

http://git.postgresql.org/gitweb/?p=slony1-engine.git;a=commit;h=b1162e018680cb6c06667cf76254080d129fff13