Bug 210 - mergeSet needs to wait for both sets to be subscribed
Summary: mergeSet needs to wait for both sets to be subscribed
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: slonik (show other bugs)
Version: devel
Hardware: PC Linux
: low enhancement
Assignee: Slony Bugs List
URL:
Depends on:
Blocks:
 
Reported: 2011-05-12 12:31 UTC by Steve Singer
Modified: 2011-05-13 13:04 UTC (History)
1 user (show)

See Also:

Attachments
patch for bug 210 (1.23 KB, patch)
2011-05-12 12:34 UTC, Steve Singer 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Singer 2011-05-12 12:31:55 UTC 
The merge set command needs to wait for both sets, the one being merged and
the one being merged into to be subscribed before merging.  

The current (2.1.0.b1) version only waits for the "add id" to be subscribed.

Otherwise a subscriber that later tries to subscribe to the other set will see
tables for both sets which might be wrong (and will fail if that subscriber is
already subscribed that other set).
Comment 1 Steve Singer 2011-05-12 12:34:42 UTC 
Created attachment 98 [details]
patch for bug 210

Someone please review this patch so we can included it in the next 2.1.0 beta
Comment 2 Christopher Browne 2011-05-12 14:20:14 UTC 
Looks good to me; compiles fine, and the intent is clearly appropriate.