<p dir="ltr">Wasn't that precisely one of our TODO items? I actually thought we did this for 2.2 already, but the code shows otherwise.<br></p>
<p dir="ltr">Jan</p>
<p dir="ltr">--<br>
Jan Wieck<br>
Senior Software Engineer<br>
<a href="http://slony.info">http://slony.info</a></p>
<div class="gmail_quote">On Jul 6, 2014 3:05 PM, "Steve Singer" <<a href="mailto:ssinger@ca.afilias.info">ssinger@ca.afilias.info</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In the copy_set function in the slon remote_worker when we copy the set from the origin we construct values for the initial snapshot (for sl_setsync) by the following method<br>
<br>
* Get the max SYNC event on the origin and snapshot information for that sync<br>
* Query all sl_log_1 and sl_log_2 entires that came in after that sync. This information populates the action list.<br>
<br>
Why don't we just get the snapshot visibility information of what is and isn't visible to the copy_set transaction directly with txid_current_snapshot() ?<br>
<br>
It seems simpler? (I would guess that this is a left-over from the pre-8.3 days when txid_current_snapshot wasn't available?)<br>
<br>
I ask because the current method work with logical replication because sl_log will be empty (but we still need the snapshot of the copy_set to filter stuff out later). I'd like to modify copy_set to just use txid_current_snapshot for both logical and trigger based cases.<br>
<br>
If there some reason why this won't work then please let me know.<br>
<br>
Thanks<br>
<br>
</blockquote></div>