Hi,

Thanks for the comments:

On Thu, 2010-07-22 at 13:48 -0400, Steve Singer wrote:

<snip>
> So start works, but stop and status don't

Weird. I have tested it on my machine. I will look.

> What is the plan for the slon_start and slon_kill perl scripts, I'd
> like  to see a big more code reuse between them (unless the plan is to
> replace them, but I am not sure how well that will go over with people
> that actually use the perl tools)

*My* plan is to add slon_ctl to 2.0 branch, so that package maintainers
can write a reliable init script easily. For HEAD, my vote is removing
slon_start, slon_kill and slon_status, and only use slon_ctl. For
backwards compatibility, we can symlink slon_ctl to slon_start, etc, and
call start,stop,status routine based on the command name.

> On the perl style side, I'd prefer to see perl code that works with
> 'use  strict' (ie declares variables).  I also don't like using the
> global scope ie shutoff_processes could return $found instead of
> changing variable defined outside the function) 

That is beyond my perl skills :)

Regards,
-- 
Devrim GÜNDÜZ
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
PostgreSQL RPM Repository: http://yum.pgrpms.org
Community: devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
http://www.gunduz.org  Twitter: http://twitter.com/devrimgunduz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.slony.info/pipermail/slony1-hackers/attachments/20100723/887eedd3/attachment.pgp