<div dir="ltr">Yes, the patch looks fine. <br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 12, 2013 at 8:01 PM, Steve Singer <span dir="ltr"><<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 12/12/2013 03:49 AM, Sandeep Thakkar wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The development package postgresql92-devel-9.2.6-<u></u>1PGDG.rhel5.x86_64.rpm<br>
and postgresql93-devel-9.3.2-<u></u>1PGDG.rhel5.x86_64.rpm at<br>
<a href="http://yum.postgresql.org/rpmchart.php" target="_blank">http://yum.postgresql.org/<u></u>rpmchart.php</a><br>
<br>
also has the port.h in the server include.<br>
</blockquote>
<br></div>
libpq-dev seems to install port.h in /usr/include/postgresql<br>
<br>
root@debian:~/slony1-engine# dpkg-query -S /usr/include/postgresql/port.h<br>
libpq-dev: /usr/include/postgresql/port.h<br>
<br>
<a href="http://packages.debian.org/sid/i386/libpq-dev/filelist" target="_blank">http://packages.debian.org/<u></u>sid/i386/libpq-dev/filelist</a><br>
<br>
The RPM packages don't port port.h there.<br>
<br>
How about the attached patch? We will add the server includes back in on pgport builds for slonik.<br>
<br>
<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
On Thu, Dec 12, 2013 at 12:23 PM, Sandeep Thakkar<br>
<<a href="mailto:sandeep.thakkar@enterprisedb.com" target="_blank">sandeep.thakkar@enterprisedb.<u></u>com</a><br></div><div class="im">
<mailto:<a href="mailto:sandeep.thakkar@enterprisedb.com" target="_blank">sandeep.thakkar@<u></u>enterprisedb.com</a>>> wrote:<br>
<br>
I see the port.h also present in the postgresql-server-dev package.<br>
Here is the list:<br>
<br>
<a href="http://packages.debian.org/sid/i386/postgresql-server-dev-9.3/filelist" target="_blank">http://packages.debian.org/<u></u>sid/i386/postgresql-server-<u></u>dev-9.3/filelist</a><br>
<br>
if you build the sources, you will find port.h always in server include.<br>
<br>
<br>
On Wed, Dec 11, 2013 at 9:28 PM, Steve Singer<br></div><div class="im">
<<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.info</a> <mailto:<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.<u></u>info</a>>> wrote:<br>
<br>
On 12/11/2013 05:14 AM, Sandeep Thakkar wrote:<br>
<br>
How did you install postgresql on Debian? I have built<br>
PosrgreSQL<br>
sources on CentOS, OSX and Windows and the port.h is<br>
installed in<br></div>
include/postgresql/server/__<u></u>port.h and<br>
include/postgresql/internal/__<u></u>port.h<br>
on all platforms.<br>
<br>
<br>
<br>
The packages from <a href="http://apt.postgresql.org" target="_blank">apt.postgresql.org</a> <<a href="http://apt.postgresql.org" target="_blank">http://apt.postgresql.org</a>><div class="im"><br>
<br>
<br>
<br>
<br>
On Sun, Dec 8, 2013 at 9:40 AM, Steve Singer<br>
<<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.info</a> <mailto:<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.<u></u>info</a>><br></div><div>
<div class="h5">
<mailto:<a href="mailto:ssinger@ca.afilias." target="_blank">ssinger@ca.afilias.</a>__<u></u>info<br>
<mailto:<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.<u></u>info</a>>>> wrote:<br>
<br>
On 11/29/2013 04:30 AM, Sandeep Thakkar wrote:<br>
<br>
The only work around I see now if to set the<br>
CPPFLAGS in the<br>
environment<br>
to the server include directory, so that<br>
CPPFLAGS_CLIENT takes<br>
it in the<br>
Makefile.global.<br>
<br>
<br>
<br>
So in debian (or at least with Wheezy) where the<br>
original bug 315<br>
was reported<br>
<br>
<br>
libpq-dev puts port.h in /usr/include/postgresql/port.h<br>
so it gets<br>
picked up by the client include paths. I am able to do<br>
a build with<br>
--with-pgport<br>
<br>
This isn't actually a problem on debian, is the problem<br>
on OSX that<br>
port.h isn't being put in the libpq header directories?<br>
Should it?<br>
Where do other platforms/distributions put port.h ?<br>
<br>
<br>
<br>
On Tue, Nov 26, 2013 at 7:05 PM, Steve Singer<br>
<<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.info</a><br>
<mailto:<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.<u></u>info</a>><br>
<mailto:<a href="mailto:ssinger@ca.afilias." target="_blank">ssinger@ca.afilias.</a>__<u></u>info<br>
<mailto:<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.<u></u>info</a>>><br></div></div>
<mailto:<a href="mailto:ssinger@ca.afilias" target="_blank">ssinger@ca.afilias</a>.<br>
<mailto:<a href="mailto:ssinger@ca.afilias" target="_blank">ssinger@ca.afilias</a>.>__<u></u>__info<div class="im"><br>
<br>
<mailto:<a href="mailto:ssinger@ca.afilias." target="_blank">ssinger@ca.afilias.</a>__<u></u>info<br>
<mailto:<a href="mailto:ssinger@ca.afilias.info" target="_blank">ssinger@ca.afilias.<u></u>info</a>>>>> wrote:<br>
<br>
On 11/26/2013 04:14 AM, Sandeep Thakkar wrote:<br>
<br>
Hi<br>
<br>
I was building Slony1-2.2.1 sources on Mac<br>
OS X and<br>
found that<br>
the build<br>
fails because of:<br>
<br>
slonik.c:49:18: error: port.h: No such<br>
file or directory<br>
CPPFLAGS is now defined to just<br>
CPPFLAGS_CLIENT that<br>
does not<br>
include<br>
the PG "server" include directory<br>
<br></div>
('<pginstall>/include/______<u></u>postgresql/server' contains<div class="im"><br>
<br>
port.h). Any<br>
<br>
specific<br>
reason why this change was made in 2.2.1?<br>
<br>
<br>
<br></div>
<a href="http://www.slony.info/______bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/______<u></u>bugzilla/show_bug.cgi?id=315</a><br>
<<a href="http://www.slony.info/____bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/____<u></u>bugzilla/show_bug.cgi?id=315</a>><div><div class="h5"><br>
<br>
<<a href="http://www.slony.info/____bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/____<u></u>bugzilla/show_bug.cgi?id=315</a><br>
<<a href="http://www.slony.info/__bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/__<u></u>bugzilla/show_bug.cgi?id=315</a>>><br>
<br>
<br>
<br>
<<a href="http://www.slony.info/____bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/____<u></u>bugzilla/show_bug.cgi?id=315</a><br>
<<a href="http://www.slony.info/__bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/__<u></u>bugzilla/show_bug.cgi?id=315</a>><br>
<br>
<<a href="http://www.slony.info/__bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/__<u></u>bugzilla/show_bug.cgi?id=315</a><br>
<<a href="http://www.slony.info/bugzilla/show_bug.cgi?id=315" target="_blank">http://www.slony.info/<u></u>bugzilla/show_bug.cgi?id=315</a>>><u></u>><br>
<br>
On systems that have multiple versions of<br>
postgresql<br>
installed might<br>
pull in files for the client from one version<br>
and server<br>
includes<br>
from another. You used to be able to get away<br>
with this<br>
but in more<br>
recent versions of PG this breaks things.<br>
<br>
I am not exactly sure what the best way to<br>
deal with this<br>
in the<br>
PGPORT case? I have a feeling just adding the<br>
server<br>
includes back<br>
in on --with-pgport builds will get us back to<br>
the bug 315<br>
situation<br>
<br>
<br>
<br>
<br>
<br>
--<br>
Sandeep Thakkar<br>
<br>
<br>
<br></div></div>
______________________________<u></u>_______________________<br>
Slony1-general mailing list<br>
Slony1-general@lists.slony.___<u></u>___info<br>
<mailto:<a href="mailto:Slony1-general@lists" target="_blank">Slony1-general@lists</a>.<br>
<mailto:<a href="mailto:Slony1-general@lists" target="_blank">Slony1-general@lists</a>.><u></u>____<a href="http://slony.info" target="_blank">slony.info</a> <<a href="http://slony.info" target="_blank">http://slony.info</a>><br>
<mailto:<a href="mailto:Slony1-general@lists." target="_blank">Slony1-general@lists.</a>_<u></u>_<a href="http://slony.info" target="_blank">slony.info</a><br>
<mailto:<a href="mailto:Slony1-general@lists.slony.info" target="_blank">Slony1-general@lists.<u></u>slony.info</a>>>><br>
<a href="http://lists.slony.info/______mailman/listinfo/slony1-______general" target="_blank">http://lists.slony.info/______<u></u>mailman/listinfo/slony1-______<u></u>general</a><br>
<<a href="http://lists.slony.info/____mailman/listinfo/slony1-____general" target="_blank">http://lists.slony.info/____<u></u>mailman/listinfo/slony1-____<u></u>general</a>><div class="im"><br>
<br>
<<a href="http://lists.slony.info/____mailman/listinfo/slony1-____general" target="_blank">http://lists.slony.info/____<u></u>mailman/listinfo/slony1-____<u></u>general</a><br>
<<a href="http://lists.slony.info/__mailman/listinfo/slony1-__general" target="_blank">http://lists.slony.info/__<u></u>mailman/listinfo/slony1-__<u></u>general</a>>><br>
<br>
<br>
<br>
<br>
<<a href="http://lists.slony.info/____mailman/listinfo/slony1-____general" target="_blank">http://lists.slony.info/____<u></u>mailman/listinfo/slony1-____<u></u>general</a><br>
<<a href="http://lists.slony.info/__mailman/listinfo/slony1-__general" target="_blank">http://lists.slony.info/__<u></u>mailman/listinfo/slony1-__<u></u>general</a>><br>
<br>
<<a href="http://lists.slony.info/__mailman/listinfo/slony1-__general" target="_blank">http://lists.slony.info/__<u></u>mailman/listinfo/slony1-__<u></u>general</a><br>
<<a href="http://lists.slony.info/mailman/listinfo/slony1-general" target="_blank">http://lists.slony.info/<u></u>mailman/listinfo/slony1-<u></u>general</a>>>><br>
<br>
<br>
<br>
<br>
<br>
--<br>
Sandeep Thakkar<br>
<br>
<br>
<br>
<br>
<br>
--<br>
Sandeep Thakkar<br>
<br>
<br>
<br>
<br>
<br>
--<br>
Sandeep Thakkar<br>
<br>
<br>
<br>
<br>
--<br>
Sandeep Thakkar<br>
<br>
</div></blockquote>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Sandeep Thakkar<div><br></div></div>
</div></div>