Christopher Browne cbbrowne at ca.afilias.info
Tue Nov 13 07:48:32 PST 2007
Cyril SCETBON <cyril.scetbon at free.fr> writes:
> I think it would be better to be able to modify SLON_DATA_FETCH_SIZE
> by using a parameter on the slon command line. For example, we got a
> lot of updates (400 per second) between far geographical sites. I had
> to modify this variable and to recompile the slon binary cause I
> didn't find another way until now.

That would definitely complicate things, as that value is, in fact,
used at compile time.

remote_worker.c:4299:	WorkerGroupLine *data_line[SLON_DATA_FETCH_SIZE];

Mind you, when it gets defined, the definition is a leetle bit odd:

#undef    SLON_CHECK_CMDTUPLES

#ifdef    SLON_CHECK_CMDTUPLES
#define SLON_COMMANDS_PER_LINE  1
#define SLON_DATA_FETCH_SIZE    100
#define SLON_WORKLINES_PER_HELPER       (SLON_DATA_FETCH_SIZE * 4)
#else
#define SLON_COMMANDS_PER_LINE  10
#define SLON_DATA_FETCH_SIZE    10
#define SLON_WORKLINES_PER_HELPER       (SLON_DATA_FETCH_SIZE * 5)
#endif

The OLD definition involved doing 1 query "per line" (well, "per query
submitted").  That changed, over time, to submitting 10 commands per
line, and evidently we still have the old definition sitting there
inactive.

This is probably worth taking a peek at for the 2.0 release...
-- 
select 'cbbrowne' || '@' || 'cbbrowne.com';
http://www3.sympatico.ca/cbbrowne/x.html
What do little birdies see when they get knocked unconscious?


More information about the Slony1-general mailing list