Tue Mar 27 14:28:12 PDT 2007
- Previous message: [Slony1-general] Problem with 1.2.8 and EXECUTE SCRIPT with multiple sets
- Next message: [Slony1-general] PostgreSQL/Slony-I: Purging Queued Replication Events
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
In Two places:
line 334 src/slonik/slonik.c:
case STMT_STORE_NODE:
{
SlonikStmt_store_node *stmt =
(SlonikStmt_store_node *) hdr;
if (stmt->ev_origin < 0)
{
stmt->ev_origin = 1;
}
and line 611 src/slonik/parser.y:
stmt_store_node : lno K_STORE K_NODE option_list
{
SlonikStmt_store_node *new;
statement_option opt[] = {
STMT_OPTION_INT( O_ID, -1 ),
STMT_OPTION_STR( O_COMMENT, NULL ),
STMT_OPTION_YN( O_SPOOLNODE, 0 ),
STMT_OPTION_INT( O_EVENT_NODE, 1 ),
STMT_OPTION_END
};
This works for 99.9% of situations, but it may be more pragmatic to use
the node ID of the least number value instead of static "1". E.g.,
default in the .y to "-1", and in the .c, to check for "-1" or
...undefined in conf = default (-1), thus check some algorithm
getLowestDefinedNodeID();
The work-around for this is to explicitly declare:
... "event node = [some_node_id_other_than_1_here]"
Which is also really inconsistent because in many other commands this
would be referred to as "node id"; that's a separate issue.
Is this feature request/ticket worthy? Also, are we presently using gborg
or pgfoundry for issue tracking?
TIA, ~BAS
--
l8*
-lava (Brian A. Seklecki - Pittsburgh, PA, USA)
http://www.spiritual-machines.org/
"...from back in the heady days when "helpdesk" meant nothing, "diskquota"
meant everything, and lives could be bought and sold for a couple of pages
of laser printout - and frequently were."
- Previous message: [Slony1-general] Problem with 1.2.8 and EXECUTE SCRIPT with multiple sets
- Next message: [Slony1-general] PostgreSQL/Slony-I: Purging Queued Replication Events
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Slony1-general mailing list