Fri Nov 4 13:43:27 PST 2005
- Previous message: [Slony1-general] Is replication the best choice?
- Next message: [Slony1-general] [patch] bug #1457: Lack of storage space for log-shipping causes replication data loss
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I have reported the problem once here on the list, and today again, on the bugtracker: http://gborg.postgresql.org/project/slony1/bugs/bugupdate.php?1457 The patch fixes the most obvious point of failure, but it seems there are other places in the code where similar problem may occur ("rc", result from file operation, is ignored most of time). Greets, Jacek -------------- next part -------------- diff -dur -x '*.orig' -x '*~' slony1-1.1.2.orig/src/slon/remote_worker.c slony1-1.1.2/src/slon/remote_worker.c --- slony1-1.1.2.orig/src/slon/remote_worker.c 2005-10-12 23:14:25.000000000 +0200 +++ slony1-1.1.2/src/slon/remote_worker.c 2005-11-02 12:40:01.000000000 +0100 @@ -4870,7 +4870,12 @@ "commit;\n" "vacuum analyze %s.sl_setsync_offline;\n", rtcfg_namespace); + if ( rc < 0 ) + return -1; rc = fclose(archive_fp); + archive_fp = NULL; + if ( rc < 0 ) + return -1; rc = rename(archive_tmp, archive_name); } return rc;
- Previous message: [Slony1-general] Is replication the best choice?
- Next message: [Slony1-general] [patch] bug #1457: Lack of storage space for log-shipping causes replication data loss
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the Slony1-general mailing list