Update of /home/cvsd/slony1/slony1-engine
In directory main:/tmp/cvs-serv16011

Modified Files:
      Tag: REL_1_2_STABLE
	UPGRADING RELEASE-1.2.7 
Log Message:
Add in notes about the "NULLable column" issue.

We had a fix in 1.2 that refuses to replicate if the PK candidate has 
columns that are NULLable.

There may be 1.1 replicas that have this condition; needed to document
how to find the problem, and deal with it, if need be...


Index: RELEASE-1.2.7
===================================================================
RCS file: /home/cvsd/slony1/slony1-engine/Attic/RELEASE-1.2.7,v
retrieving revision 1.1.2.4
retrieving revision 1.1.2.5
diff -C2 -d -r1.1.2.4 -r1.1.2.5
*** RELEASE-1.2.7	8 Feb 2007 22:55:57 -0000	1.1.2.4
--- RELEASE-1.2.7	16 Feb 2007 23:36:18 -0000	1.1.2.5
***************
*** 29,30 ****
--- 29,33 ----
  STRICT; the absence of this caused postmaster to fall over when
  processing MOVE SET event in PG v8.2
+ 
+ - Added documentation of an issue surrounding NULLABLE columns to the
+ log analysis chapter of the admin guide and to the UPGRADING docs.

Index: UPGRADING
===================================================================
RCS file: /home/cvsd/slony1/slony1-engine/UPGRADING,v
retrieving revision 1.1.4.1
retrieving revision 1.1.4.2
diff -C2 -d -r1.1.4.1 -r1.1.4.2
*** UPGRADING	2 Jan 2007 17:04:09 -0000	1.1.4.1
--- UPGRADING	16 Feb 2007 23:36:18 -0000	1.1.4.2
***************
*** 29,30 ****
--- 29,65 ----
  The section is entitled "Slony-I Upgrade", distributed as
  doc/adminguide/slonyupgrade.html in the documentation package.
+ 
+ Nullable Column issue in version 1.2
+ ===================================
+ 
+ In version 1.2, a check has been added to reject subscriptions to
+ tables where the candidate primary key has columns that are "Nullable"
+ (e.g. - that are not defined in the schema as NOT NULL).
+ 
+ This was not checked in earlier versions, and people may have set up
+ constraints (e.g. - via triggers) to enforce NOT NULL as opposed to
+ using the NOT NULL column constraint.  As a result, a replica running
+ on version 1.1 may have violations of this check.
+ 
+ You may search for these violations via the following query:
+ 
+ select c.relname as table_name, ic.relname as index_name, att.attname, att2.attnotnull
+ from _cluster.sl_table t, pg_catalog.pg_class c, pg_index i, pg_catalog.pg_class ic, pg_catalog.pg_attribute att, pg_catalog.pg_attribute att2
+ where t.tab_reloid = c.oid 
+     and t.tab_idxname = ic.relname 
+     and  ic.oid = i.indexrelid
+     and att.attrelid = i.indexrelid
+     and att2.attname = att.attname
+     and att2.attrelid = c.oid
+     and att2.attnotnull = 'f';
+ 
+ The problem may be rectified by submitting, for each entry found, a
+ query of the form:
+    alter table mytable alter column nullablecol set not null;
+ 
+ It would minimally suffice to apply this to the schema of new
+ subscribers; such queries will run rapidly against empty tables.
+ 
+ It will take longer to apply this change to a table that already
+ contains a great deal of data, as the alteration will scan the table
+ to verify that there are no tuples where the column is NULL.