Log Message:
-----------
FEATURE REQUEST #1443 - add cluster name to "Node is uninitialized" error message

During a switchover test, we got the following error message:

ERROR: Slony-I: Node is uninitialized

It happened because a table we were using for a heartbeat monitor
erroneously had an extra slony trigger on place for a different (no
longer active) slony cluster.

Totally strange circumstance, and totally my fault, but debug time would
have been much reduced if the error message had told us which node in
which cluster was not initialised.

Is there any chance that this information could be added to the error
message in a future release?

marc <NOSPAM> bloodnok.com
---------------------------------------------------
Have added a patch to CVS HEAD that lists the cluster name.
Unfortunately, the node number is not available at the point in the code
where this error message is issued.

cbbrowne at ca.afilias.info

Modified Files:
--------------
    slony1-engine/src/backend:
        slony1_funcs.c (r1.37 -> r1.38)

-------------- next part --------------
Index: slony1_funcs.c
===================================================================
RCS file: /usr/local/cvsroot/slony1/slony1-engine/src/backend/slony1_funcs.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -Lsrc/backend/slony1_funcs.c -Lsrc/backend/slony1_funcs.c -u -w -r1.37 -r1.38
--- src/backend/slony1_funcs.c
+++ src/backend/slony1_funcs.c
@@ -1255,7 +1255,7 @@
 										SPI_getbinval(SPI_tuptable->vals[0], SPI_tuptable->tupdesc, 1, &isnull));
 		SPI_freetuptable(SPI_tuptable);
 		if (cs->localNodeId < 0)
-			elog(ERROR, "Slony-I: Node is uninitialized");
+			elog(ERROR, "Slony-I: Node is uninitialized - cluster %s", cluster_name);
 
 		/*
 		 * Initialize the currentXid to invalid
@@ -1270,7 +1270,7 @@
 	}
 
 	/*
-	 * Prepare and save the PLAN_NOTIFT_EVENT
+	 * Prepare and save the PLAN_NOTIFY_EVENT
 	 */
 	if ((need_plan_mask & PLAN_NOTIFY_EVENT) != 0 &&
 		(cs->have_plan & PLAN_NOTIFY_EVENT) == 0)