http://www.slony.info/bugzilla/show_bug.cgi?id=315

--- Comment #1 from Steve Singer <ssinger at ca.afilias.info> 2013-09-12 08:43:47 PDT ---
Created an attachment (id=184)
 --> (http://www.slony.info/bugzilla/attachment.cgi?id=184)
be more careful about how we set CPPFLAGS

I worked through this with athanasios on  IRC.

He had libpq-dev and libpq5 versions 9.3 from the PGDG apt repository
installed.
He also had postgresql-server-dev-8.4 installed since he was going to be using
PG 8.4

The libpq-dev package puts files in /usr/include/postgresql   while the header
files for the server live in /usr/include/postgresql/8.4/server

Our configure checks were including both -I/usr/include/postgresql and
-I/usr/include/postgresql/8.4/server and with a 9.3 libpq HEADERS this causes
compile errors because some header files are from one version and some from the
other.  Having  libpq-dev 9.1 and PG-server-dev-8.4 happens to work fine.

We really should be more careful about if we want server headers or libpq
headers.  The slony code doesn't seem to mix these but we aren't careful enough
about the CPPFLAGS we use.

This patch tries to be more careful.  I have only tested it on Debian wheezy
with the 8.4  / libpq-dev 9.3 combination identified here.

I think we will need to address this issue in 2.1 , 2.2 I think we will start
to see more complaints about this as people upgrade there libpq to 9.3 while
they still have a older server.

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.