bugzilla-daemon at main.slony.info bugzilla-daemon at main.slony.info
Wed Mar 16 13:46:31 PDT 2011
http://www.slony.info/bugzilla/show_bug.cgi?id=175

--- Comment #12 from Christopher Browne <cbbrowne at ca.afilias.info> 2011-03-16 13:46:31 PDT ---
Per Steve's recommendation, monitoring thread problems aren't necessarily
serious problems warranting restarting the slon.

This patch implements that:
https://github.com/cbbrowne/slony1-engine/commit/d1a5be153e51cd10ac12a3dcb9cbb63856a18306

Note that there are still some slon_retry() calls remaining, in the scenario
where the slon process runs out of memory.  That seems pretty fatal to me...

I realized that there are cases where we have a horrid memory leak; if the
monitoring thread isn't working, then we shouldn't be collecting monitoring
entries.  Thus, made two changes:

1.  When we exit from the monitoring thread main loop, turn monitoring off.

2.  In the "push" function, if monitoring is shut off, return immediately, do
not attempt to queue up monitoring data.

https://github.com/cbbrowne/slony1-engine/commit/a61f4642ed29bc727d2361a4000500b81573ea11

I realized that the one entry for the monitoring thread will indicate the time
when the slon daemon started.  Document that...

https://github.com/cbbrowne/slony1-engine/commit/d3f66cccb54168ca8d6a80261337a66228720cd8

-- 
Configure bugmail: http://www.slony.info/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Slony1-bugs mailing list