Christopher Browne cbbrowne at ca.afilias.info
Tue Jul 14 11:51:16 PDT 2009
Sachin Srivastava <sachin.srivastava at enterprisedb.com> writes:
> When i run the slonik command i get this warning:
> Possible unsupported PostgreSQL version (80400) 8.4, defaulting to 8.3 support.

The patch is close to right...  I'd rather go with...

Index: slonik/slonik.c
===================================================================
RCS file: /home/cvsd/slony1/slony1-engine/src/slonik/slonik.c,v
retrieving revision 1.91.2.2
diff -c -u -r1.91.2.2 slonik.c
cvs diff: conflicting specifications of output style
--- slonik/slonik.c     17 Jun 2009 21:37:38 -0000      1.91.2.2
+++ slonik/slonik.c     14 Jul 2009 18:47:20 -0000
@@ -1799,7 +1799,12 @@
                use_major = 8;
                use_minor = 3;
        }
-       else    /* above 8.3 ??? */
+       else if ((adminfo->pg_version >= 80400) && (adminfo->pg_version < 80500)) /* 8.4 */
+       {
+               use_major = 8;
+               use_minor = 3;   /* at this point, there's nothing specifically different in 8.4 from 8.3 */
+       }
+       else    /* above 8.4 ??? */
        {
                use_major = 8;
                use_minor = 3;

The point of use_major/use_minor is to pick which additional schema
files to load.

We haven't had any 8.4-specific variances, so we can safely use the
8.3 schema files, hence I identify 8.4 as being "the same as 8.3."
-- 
let name="cbbrowne" and tld="ca.afilias.info" in name ^ "@" ^ tld;;
<http://dba2.int.libertyrms.com/>
Christopher Browne
(416) 673-4124 (land)
"Bother,"  said Pooh,  "Eeyore, ready  two photon  torpedoes  and lock
phasers on the Heffalump, Piglet, meet me in transporter room three"


More information about the Slony1-bugs mailing list