Peter Eisentraut wrote:
> Am Donnerstag, 14. Juni 2007 17:52 schrieb Christopher Browne:
>   
>> Peter, I just exported a tarball for 1.2.10 yesterday, and would like to
>> see about fixing remaining permissions problems.
>>
>> http://lists.slony.info/downloads/1.2/source/slony1-1.2.10-pre.tar.bz2
>>     
>
> Quite evidently, there are still a bunch of files executable.  I'd say nothing 
> except for the top level configure script should be.  With perhaps a few 
> other enumerated exceptions.  But there shouldn't be that many files.
>   
Well, there are 63 shell scripts, Perl scripts, and Perl .pm files with
executable perms.  For them to be executable seems appropriate; I don't
plan to touch those.

cbbrowne at dba2:/opt/OXRS/sources> tar tfvj slony1-1.2.10-pre.tar.bz2 |
grep rwx | egrep -v "^drwxr" | egrep ".(pl|sh|pm)$" | wc -l
63

If I exclude them, I am left with the following:

cbbrowne at dba2:/opt/OXRS/sources> tar tfvj slony1-1.2.10-pre.tar.bz2 |
grep rwx | egrep -v "^drwxr" | egrep -v ".(pl|sh|pm)$"    
-rwxr-xr-- cbbrowne/users   121 2004-07-12 20:34
slony1-1.2.10-pre/.cvsignore
-rwxr-xr-x cbbrowne/users 336968 2007-06-13 16:16
slony1-1.2.10-pre/configure
-rwxr-xr-- cbbrowne/users     68 2005-05-10 16:56
slony1-1.2.10-pre/doc/concept/.cvsignore
-rwxr-xr-- cbbrowne/users     89 2005-05-19 22:26
slony1-1.2.10-pre/doc/implementation/.cvsignore
-rwxr-xr-x cbbrowne/users   2749 2007-06-05 18:25
slony1-1.2.10-pre/redhat/postgresql-slony1-engine.init
-rwxr-xr-x cbbrowne/users   8929 2007-06-11 05:54
slony1-1.2.10-pre/redhat/postgresql-slony1-engine.specfile
-rwxr-xr-- cbbrowne/users      0 2004-03-30 18:47
slony1-1.2.10-pre/src/backend/.cvsignore
-rwxr-xr-- cbbrowne/users    289 2005-11-22 05:29
slony1-1.2.10-pre/src/ducttape/.cvsignore
-rwxr-xr-- cbbrowne/users     27 2004-10-11 14:12
slony1-1.2.10-pre/src/slon/.cvsignore
-rwxr-xr-- cbbrowne/users     31 2004-10-11 14:12
slony1-1.2.10-pre/src/slonik/.cvsignore
-rwxr-xr-- cbbrowne/users      6 2003-11-17 17:29
slony1-1.2.10-pre/src/xxid/.cvsignore
-rwxr-xr-- cbbrowne/users    407 2006-03-28 21:18
slony1-1.2.10-pre/tests/one-offs/bug1538/README
-rwxr-xr-- cbbrowne/users    813 2006-03-28 21:18
slony1-1.2.10-pre/tests/one-offs/bug1538/build-and-populate-single-node
-rwxr-xr-- cbbrowne/users   5216 2005-11-15 18:09
slony1-1.2.10-pre/tools/altperl/slon_tools.conf-sample
-rwxr-xr-- cbbrowne/users    550 2006-11-02 21:56
slony1-1.2.10-pre/tools/awk-for-stored-proc-vers.awk
-rwxr-xr-- cbbrowne/users   5564 2006-11-07 16:02
slony1-1.2.10-pre/tools/configure-replication.txt

I just changed "make distclean" to clean out the .cvsignore files, so
those will disappear altogether; we don't care about permissions about
files that are gone.

The two files in the redhat/ directory I'm not sure about.

There's a README and a .txt file that need not to be executable.

That leaves us with 3 files...

build-and-populate-single-node is a shell script.  Executable should be
OK on that.

slon_tools.conf-sample is Perl code.  I don't think it's particularly
wrong for that to be executable.

awk-for-stored-proc-vers.awk is an Awk script; it doesn't *need* to be
executable, but I don't think that's desperately wrong.

I see two files, at this point, that I'm sure ought to be changed to not
be executable.  Adding that to "make cvsdistclean"...

I'm preferring to see it as OK to have the numerous scripts be marked as
executable, which seems to me to be a matter of taste.  Am I
misunderstanding the importance of making things executable?