Bug 200 - slon_retry() overused
Summary: slon_retry() overused
Status: NEW
Alias: None
Product: Slony-I
Classification: Unclassified
Component: slon (show other bugs)
Version: devel
Hardware: All All
: medium enhancement
Assignee: Slony Bugs List
Depends on:
Reported: 2011-03-15 14:48 UTC by Christopher Browne
Modified: 2011-03-15 14:48 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Browne 2011-03-15 14:48:44 UTC
Noticed in bug #175...

There are a LOT of places where slon_retry() is called, which signals a start of the slon daemon.

local_listener.c: 8
cleanup_thread.c: 4
remote_worker.c: 45
sync_thread.c: 5
misc.c: 3
runtime_config.c: 15
slon.c: 15

This seems rather excessive - if a problem occurs in any of these places, this effectively terminates all activity that's going on.  If a 2-day-long subscription is taking place, then any little problem that occurs in a peripheral area will take that down and restart it.

Some assessment should take place to determine the degree to which this is excessive.  There are legitimately problems that are fatal that warrant terminating/restarting the slon daemon.  But probably not *quite* this many...