Bug 54 - various bashisms
Summary: various bashisms
Status: RESOLVED FIXED
Alias: None
Product: Slony-I
Classification: Unclassified
Component: other scripts (show other bugs)
Version: 1.2
Hardware: Other Linux
: medium normal
Assignee: Slony Bugs List
URL: http://bugs.debian.org/cgi-bin/bugrep...
Depends on:
Blocks:
 
Reported: 2008-07-07 06:11 UTC by Peter Eisentraut
Modified: 2008-07-07 14:17 UTC (History)
1 user (show)

See Also:


Attachments
patch (13.05 KB, patch)
2008-07-07 06:11 UTC, Peter Eisentraut
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Eisentraut 2008-07-07 06:11:15 UTC
Created attachment 19 [details]
patch

There are many bashisms and other nonportable shell features used in the various scripts in the slony tree.  Most of them are easily fixable.  In other cases, it might be easier to change #!/bin/sh to #!/bin/bash.

I have attached a patch that should fix a number of those problems.
Comment 1 Christopher Browne 2008-07-07 14:17:41 UTC
Thanks, Peter!

It applied nicely against CVS HEAD, and I ran some of the regression tests successfully, so it seems safe enough to commit.

I tried applying it to the 1.2 branch with less success; I think I'll leave this as a "HEAD enhancement," unless people have great objections...

http://lists.slony.info/pipermail/slony1-commit/2008-July/002315.html
http://lists.slony.info/pipermail/slony1-commit/2008-July/002316.html
http://lists.slony.info/pipermail/slony1-commit/2008-July/002317.html
http://lists.slony.info/pipermail/slony1-commit/2008-July/002318.html
http://lists.slony.info/pipermail/slony1-commit/2008-July/002319.html